fgerlits commented on code in PR #1725:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1725#discussion_r1514369116
##########
libminifi/include/core/ProcessGroup.h:
##########
@@ -205,6 +205,8 @@ class ProcessGroup : public CoreComponent {
*/
std::shared_ptr<core::controller::ControllerServiceNode>
findControllerService(const std::string &nodeId) const;
+ std::vector<std::shared_ptr<core::controller::ControllerServiceNode>>
getAllControllerServices() const;
Review Comment:
They can't be null, but I think `not_null` should be added to the container
in `ControllerServiceMap`, so I would prefer to do this as part of
MINIFICPP-2312.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
