bobpaulin commented on PR #8500: URL: https://github.com/apache/nifi/pull/8500#issuecomment-1997399643
> Thanks for the contribution @bobpaulin, enabling Python extensions on Windows is a helpful step forward. > > Although the new property provides a level of flexibility, it also presents some complexity. I do not run on Windows as frequently, but if `bin` is the common directory on macOS and Linux, and `Scripts` is common on Windows, it seems possible to check for the existence of each sub-directory and select one accordingly. That would avoid the need for a new property and the potential complexity. What do you think about that approach? Hi @exceptionfactory thanks for the quick reply. Yes I am open to a more automated approach see [1] . I think checking the parent directory for the sub-directory rather than specifically checking for OS might be much simpler. However not being familiar with how stable venv is do you think it makes sense to implement this as a filter config for which directories to check? EX ``` nifi.python.virtual.env.binary.directory.filter=bin,Scripts ``` That way if venv introduces a change users can simply add the directory to the list? [1] https://lists.apache.org/thread/gfdm5w3dw4zm6rhsswk71gj8pg3d21m3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
