exceptionfactory commented on PR #8500: URL: https://github.com/apache/nifi/pull/8500#issuecomment-1997669153
> > Thanks for the reply and reference to the mailing list thread @bobpaulin. > > Reviewing the [Python Virtual Environments documentation](https://docs.python.org/3/tutorial/venv.html) and a [Python venv tutorial](https://python.land/virtual-environments/virtualenv), `Scripts` seems to be the standard directory for Windows and `bin` seems to be standard for macOS and Linux. > > Given that background, I think directory-existence checking would be the ideal way forward. It avoids having to evaluate the OS System properties, and also avoids the need for a new NiFi property. > > If we run into issues down the road, then something along the lines of the filter property you described seems worth considering. For now, however, checking first for `bin` and then for `Scripts` seems like it should cover current behavior. > > Hi @exceptionfactory . Yes I think we're aligned on using directory over OS detection. And I agree there is less changes required if we simply hard code the check for first bin then Scripts into the code. Naturally the tradeoff is less complexity with requiring a Nifi release to adapt if venv changes vs a more complex change upfront . It sounds like you're saying at this point your read is the property is more trouble than it's worth. I'll bring this conversation back on list and adjust my PR as advised. Thanks again for the quick reply. Yes, that's a good summary. Thanks for moving this forward! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
