james-elliott commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525219634
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/resizable/resizable.component.scss:
##########
@@ -25,8 +25,8 @@ $handle-size: 15px;
.resizable-handle {
position: absolute;
- width: $handle-size;
- height: $handle-size;
Review Comment:
Why did you remove the variable and replace it with a set size?
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.html:
##########
Review Comment:
The border classes here aren't impacting styling. They're getting overridden
by the border styling on line 45 of _prioritizers.component-theme.scss
They can either be removed, or the styling rules overriding them need to be
removed so they match the behavior of the parameter context inheritance drag &
drop.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/navigation-control/navigation-control.component.scss:
##########
@@ -18,9 +18,12 @@
div.navigation-control {
margin-bottom: 2px;
- .fa,
- .icon {
- font-size: 18px;
+ .mat-mdc-icon-button {
+ height: 34px !important;
+ width: 34px !important;
+ line-height: 34px;
+ font-size: 17px !important;
+ padding: 0px !important;
Review Comment:
Rather than using !important because this is in a scoped context of the
navigation control, we can set new values for the material variables, and it'll
only affect items in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
