mcgilman commented on code in PR #8499:
URL: https://github.com/apache/nifi/pull/8499#discussion_r1525421743
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.html:
##########
@@ -72,7 +72,7 @@
} @else {
@if (asBulletinEvent(item); as event) {
<li class="w-full mt-4">
- <div class="border-b-2 flex-1 p-2">
+ <div class="bulletin-board-event border-b-2
flex-1 p-2">
Review Comment:
I don't see this class defined anyplace.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##########
@@ -21,7 +21,7 @@ <h2 mat-dialog-title>Add Users/Groups To Policy</h2>
@if (filteredUsers.length > 0) {
<div>
<mat-label>Users</mat-label>
- <mat-selection-list formControlName="users" class="border">
+ <mat-selection-list formControlName="users">
Review Comment:
We the intention to remove the border here? Or was something meant to
replace it?
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.scss:
##########
@@ -17,14 +17,10 @@
.prioritizers {
.prioritizers-list {
- min-height: 66px;
+ min-height: 74px;
border-radius: 4px;
overflow: hidden;
display: block;
-
- .cdk-drag-disabled {
- cursor: not-allowed;
- }
Review Comment:
With this style removed, the user is no longer shown the `not-allowed`
cursor when the prioritizers control is disabled.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##########
@@ -95,6 +95,10 @@
fill: $warn-palette-lighter;
}
+ .warn-default {
+ fill: $warn-palette-default;
+ }
+
Review Comment:
I think `.warn-default` is already defined in this file below.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-inheritance/parameter-context-inheritance.component.scss:
##########
@@ -17,14 +17,10 @@
.parameter-context-inheritance {
.parameter-context-inheritance-list {
- min-height: 66px;
+ min-height: 74px;
border-radius: 4px;
overflow: hidden;
display: block;
-
- .cdk-drag-disabled {
- cursor: not-allowed;
- }
Review Comment:
With this style removed, the user is no longer shown the `not-allowed`
cursor when the parameter context inheritance control is disabled.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-to-policy-dialog.component.html:
##########
@@ -33,7 +33,7 @@ <h2 mat-dialog-title>Add Users/Groups To Policy</h2>
@if (filteredUserGroups.length > 0) {
<div [class.mt-4]="filteredUsers.length > 0">
<mat-label>User Groups</mat-label>
- <mat-selection-list formControlName="userGroups"
class="border">
+ <mat-selection-list formControlName="userGroups">
Review Comment:
We the intention to remove the border here? Or was something meant to
replace it?
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-tenant/edit-tenant-dialog.component.html:
##########
@@ -37,7 +37,7 @@ <h2 mat-dialog-title>{{ isNew ? 'Add' : 'Edit' }} {{ isUser ?
'User' : 'User Gro
@if (isUser) {
<div>
<mat-label>Member of</mat-label>
- <mat-selection-list formControlName="userGroups"
class="border">
+ <mat-selection-list formControlName="userGroups">
Review Comment:
This border was removed.
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/edit-tenant/edit-tenant-dialog.component.html:
##########
@@ -48,7 +48,7 @@ <h2 mat-dialog-title>{{ isNew ? 'Add' : 'Edit' }} {{ isUser ?
'User' : 'User Gro
} @else {
<div>
<mat-label>Members</mat-label>
- <mat-selection-list formControlName="users" class="border">
+ <mat-selection-list formControlName="users">
Review Comment:
This border was removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
