exceptionfactory commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1539537745
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##########
@@ -340,7 +356,7 @@ protected void getListing(final String path, final int
depth, final int maxResul
if (isIncludedFile(entry, symlink) && (filteringDisabled ||
pathMatched)) {
if (filteringDisabled || fileFilterPattern == null ||
fileFilterPattern.matcher(entryFilename).matches()) {
- listing.add(newFileInfo(entry, path));
+ listing.add(newFileInfo(path, entry.getName(),
entry.getAttributes()));
Review Comment:
Very good point @EndzeitBegins, on closer inspection, I agree with you that
the null check there should be unnecessary given that it would have failed in
`isIncludedFile()` based on current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
