exceptionfactory commented on code in PR #8503:
URL: https://github.com/apache/nifi/pull/8503#discussion_r1538557100
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##########
@@ -340,7 +356,7 @@ protected void getListing(final String path, final int
depth, final int maxResul
if (isIncludedFile(entry, symlink) && (filteringDisabled ||
pathMatched)) {
if (filteringDisabled || fileFilterPattern == null ||
fileFilterPattern.matcher(entryFilename).matches()) {
- listing.add(newFileInfo(entry, path));
+ listing.add(newFileInfo(path, entry.getName(),
entry.getAttributes()));
Review Comment:
This change does not account for the possibility of `entry` being `null` as
implied by the previous behavior.
##########
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java:
##########
@@ -340,7 +356,7 @@ protected void getListing(final String path, final int
depth, final int maxResul
if (isIncludedFile(entry, symlink) && (filteringDisabled ||
pathMatched)) {
if (filteringDisabled || fileFilterPattern == null ||
fileFilterPattern.matcher(entryFilename).matches()) {
- listing.add(newFileInfo(entry, path));
+ listing.add(newFileInfo(path, entry.getName(),
entry.getAttributes()));
Review Comment:
In this particular context, the `RemoteResourceInfo` may not return
directory status if the path is a symbolic link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
