slambrose commented on PR #8536:
URL: https://github.com/apache/nifi/pull/8536#issuecomment-2023618547
Thanks for taking another look :)
So, the storageLocation change is still needed to fix the bug and process
the flow in stateless. Otherwise, when it loops down to pull the sub-versioned
process flow, it'll append the /{bucketId}/{flowId} parameters twice and make a
bad call to the registry-api. The best way I came up to fix that was just to
make sure to start with the base registry url and append the storage location
parameters to always construct a valid registryUrl. I noticed the 1.x support
branch was originally setting the registryUrl to coordinates.getRegistryUrl(),
which was changed to coordinates.getStorageLocation() in main. This fix works
for the 1.x branch as well.
Do you have another value other than "1" you'd prefer me to set it to? FYI -
it has to be a static value in order for all of the current tests to work.
I can work on adding some unit tests for both of these fixes. I'll add a
comment here when I commit them and are ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
