slambrose commented on code in PR #8536:
URL: https://github.com/apache/nifi/pull/8536#discussion_r1551746576
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##########
@@ -509,6 +509,8 @@ private String determineRegistryId(final
VersionedFlowCoordinates coordinates) {
} else {
return explicitRegistryId;
}
+ } else {
+ explicitRegistryId = "1";
Review Comment:
@exceptionfactory - So your most recent comment on my PR led me down an
interesting path. I see what you mean about looking into the subsequent call
using the storageLocation. What's interesting about that is Stateless flows
always ever use the InMemoryFlowRegistry.class , and then therefore that call:
`try {
locationApplicable =
flowRegistryClientNode.isStorageLocationApplicable(location);
} catch (final Exception e) {
LOG.error("Unable to determine if {} is an applicable Flow Registry
Client for storage location {}", flowRegistryClientNode, location, e);
continue;
}
if (locationApplicable) {
LOG.debug("Found Flow Registry Client {} that is applicable for storage
location {}", flowRegistryClientNode, location);
return flowRegistryClientNode.getIdentifier();
}`
So for stateless, the locationApplication is always false
InMemoryFlowRegistry:
`@Override
public boolean isStorageLocationApplicable(final
FlowRegistryClientConfigurationContext context, final String location) {
return false;
}`
So, basically the only way to fix stateless is to either keep the "1" for
registryId fix, or try to set this isStorageLocationApplication method for the
in memory registry to true....although I'm sure that will probably break other
things. Do you have any opinion on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
