szaszm commented on code in PR #1749:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1555897674
##########
README.md:
##########
@@ -185,7 +184,7 @@ On all distributions please use -DUSE_SHARED_LIBS=OFF to
statically link zlib, l
#### Libraries
* libuuid
* librocksdb (built and statically linked)
-* libcurl-openssl (If not available or desired, NSS will be used)
+* libcurl-openssl
Review Comment:
```suggestion
* libcurl-openssl (built and statically linked)
```
##########
libminifi/CMakeLists.txt:
##########
@@ -78,17 +76,17 @@ endif()
include(RangeV3)
include(Asio)
include(MagicEnum)
-list(APPEND LIBMINIFI_LIBRARIES yaml-cpp ZLIB::ZLIB concurrentqueue RapidJSON
spdlog Threads::Threads gsl-lite libsodium range-v3 expected-lite date::date
date::tz asio magic_enum)
+list(APPEND LIBMINIFI_LIBRARIES yaml-cpp ZLIB::ZLIB concurrentqueue RapidJSON
spdlog Threads::Threads gsl-lite libsodium range-v3 expected-lite date::date
date::tz asio magic_enum OpenSSL::Crypto OpenSSL::SSL CURL::libcurl RapidJSON)
if(NOT WIN32)
list(APPEND LIBMINIFI_LIBRARIES OSSP::libuuid++)
endif()
-if (MINIFI_OPENSSL)
- list(APPEND LIBMINIFI_LIBRARIES OpenSSL::Crypto OpenSSL::SSL)
-endif()
if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION
VERSION_LESS 9)
list(APPEND LIBMINIFI_LIBRARIES stdc++fs)
endif()
target_link_libraries(core-minifi ${CMAKE_DL_LIBS} ${LIBMINIFI_LIBRARIES})
+if (APPLE)
+ target_link_libraries(core-minifi "-framework CoreFoundation -framework
SystemConfiguration")
+endif()
Review Comment:
Was this moved from somewhere else, or what made this necessary?
##########
libminifi/test/unit/SchedulingAgentTests.cpp:
##########
@@ -63,8 +64,8 @@ class SchedulingAgentTestFixture {
count_proc_->setScheduledState(core::RUNNING);
#ifdef WIN32
- utils::dateSetInstall(TZ_DATA_DIR);
date::set_install(TZ_DATA_DIR);
+ minifi::utils::timeutils::dateSetInstall(TZ_DATA_DIR);
Review Comment:
Why was this reordered?
##########
arch.sh:
##########
@@ -31,10 +31,9 @@ bootstrap_compiler(){
sudo pacman -S --noconfirm gcc
}
build_deps(){
- COMMAND="sudo pacman -S --noconfirm --needed cmake zlib openssl util-linux
make patch which pkgconf"
+ COMMAND="sudo pacman -S --noconfirm --needed cmake zlib openssl util-linux
make patch which pkgconf perl bzip2 curl"
Review Comment:
Doesn't OpenSSL also need NASM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
