adamdebreceni commented on code in PR #1749:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1749#discussion_r1568862478
##########
extensions/expression-language/tests/integration/UpdateAttributeIntegrationTest.cpp:
##########
@@ -38,11 +38,10 @@ class TestHarness : public IntegrationBase {
}
void runAssertions() override {
- using org::apache::nifi::minifi::utils::verifyLogLinePresenceInPollTime;
-
assert(verifyLogLinePresenceInPollTime(std::chrono::milliseconds(wait_time_),
+
REQUIRE(minifi::test::utils::verifyLogLinePresenceInPollTime(std::chrono::milliseconds(wait_time_),
"key:route_check_attr value:good",
"key:variable_attribute value:replacement_value"));
- assert(false ==
verifyLogLinePresenceInPollTime(std::chrono::milliseconds(200), "ProcessSession
rollback")); // No rollback happened
+ REQUIRE(false ==
minifi::test::utils::verifyLogLinePresenceInPollTime(std::chrono::milliseconds(200),
"ProcessSession rollback")); // No rollback happened
Review Comment:
REQUIRE_FALSE?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
