rfellows commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557642603
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss:
##########
@@ -126,15 +38,14 @@ $material-theme-light: mat.define-light-theme(
accent: $material-accent-light,
warn: $warn-light
),
- //typography: mat.define-typography-config(), // TODO: typography
- density: -3
+ density: -1
Review Comment:
I think this density needs to be `-3`. We have double scrollbars on the
processor configuration dialog's properties tab without it.
<img width="776" alt="Screenshot 2024-04-09 at 9 10 43 AM"
src="https://github.com/apache/nifi/assets/713866/82250e58-33fa-455e-bcba-0da4b4eea524";>
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
##########
@@ -265,11 +199,11 @@
}
text.processor-type {
- fill: utils.get-color-on-surface($color-config, $surface,
'accent');
+ fill: utils.get-color-on-surface($material-theme-color-config,
$surface, 'accent');
}
Review Comment:
do we need to have a similar treatment on the text.processor-icon? I noticed
in purple mode, the icon on the canvas for a processor looks like it isn't
themed and doesn't match the icon in the operation panel. The other component
types seem to have the expected color
<img width="704" alt="Screenshot 2024-04-09 at 9 26 10 AM"
src="https://github.com/apache/nifi/assets/713866/1a2fbc3c-a7d4-4ae6-8197-1e2719041052";>
<img width="703" alt="Screenshot 2024-04-09 at 9 32 54 AM"
src="https://github.com/apache/nifi/assets/713866/c0b095a9-5b5b-472e-a21c-f0e53334019a";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
