james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557682396
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/port-manager.service.ts:
##########
@@ -449,7 +449,7 @@ export class PortManager {
return '\ue80a';
}
})
- .classed('transmitting', function (d: any) {
+ .classed('nifi-success-default', function (d: any) {
Review Comment:
This was introduced in an earlier change from NIFI-12870. I changed it to a
green to match ".running".
"Blue means transmitting and green means running" is a much more complex,
and not super helpful use of color versus "green means it's on and working". By
connecting the concepts and reducing the number of different colors used it
makes theming more straightforward. Themes only need to consider one color for
"it's working" versus having to select multiple colors for conceptually
identical information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]