fgerlits commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1549915952
##########
extensions/python/PythonCreator.h:
##########
@@ -78,6 +80,11 @@ class PythonCreator : public minifi::core::CoreComponent {
class_name = full_name;
}
if (path.string().find("nifi_python_processors") != std::string::npos) {
+ auto utils_path = std::string("nifi_python_processors").append(1,
utils::file::getSeparator()).append("utils");
Review Comment:
why not
```suggestion
auto utils_path = (std::filesystem::path("nifi_python_processors") /
"utils").string();
```
? then we wouldn't need the `getSeparator()` function
##########
msi/WixWin.wsi.in:
##########
@@ -437,6 +438,11 @@ ${WIX_EXTRA_COMPONENTS}
<Component Id="NifiPythonProcessorFiles"
Guid="66ce16d4-aea4-4fcb-bbbb-8a28813e2138">
<File Id="NifiPythonProcessors_init" Name="__init__.py"
KeyPath="yes"
Source="..\extensions\python\pythonprocessors\nifi_python_processors\__init__.py"/>
</Component>
+ <Directory Id="INSTALLNIFIPYTHONPROCESSORSUTILSDIR"
Name="utils">
+ <Component Id="NifiPythonProcessorUtilsFiles"
Guid="6bb11f67-007f-4467-970a-c42c2bae0891">
+ <File Id="NifiPythonProcessorUtils_dependendcy_installer"
Name="inline_dependency_installer.py" KeyPath="yes"
Source="..\extensions\python\pythonprocessors\nifi_python_processors\utils\inline_dependency_installer.py"/>
Review Comment:
nitpicking:
```suggestion
<File Id="NifiPythonProcessorUtils_dependency_installer"
Name="inline_dependency_installer.py" KeyPath="yes"
Source="..\extensions\python\pythonprocessors\nifi_python_processors\utils\inline_dependency_installer.py"/>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
