szaszm commented on code in PR #1727:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1727#discussion_r1560985716
##########
docker/test/integration/cluster/ImageStore.py:
##########
@@ -97,10 +105,21 @@ def __build_minifi_cpp_sql_image(self):
return self.__build_image(dockerfile)
- def __build_minifi_cpp_image_with_nifi_python_processors(self,
additional_cmd=""):
+ def __build_minifi_cpp_image_with_nifi_python_processors(self,
python_option):
parse_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-"; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ParseDocument.py"
chunk_document_url =
"https://raw.githubusercontent.com/apache/nifi/rel/nifi-"; +
NifiContainer.NIFI_VERSION +
"/nifi-python-extensions/nifi-text-embeddings-module/src/main/python/ChunkDocument.py"
pip3_install_command = ""
+ requirements_install_command = ""
+ additional_cmd = ""
+ parse_document_sed_cmd = 'sed -i "54d;55d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ParseDocument.py
&& \\'
+ chunk_document_sed_cmd = 'sed -i "112d"
/opt/minifi/minifi-current/minifi-python/nifi_python_processors/ChunkDocument.py
&& \\'
Review Comment:
Could you please add a comment with the description of what each part of the
pattern means? Regex is write-only, it's not super obvious what is happening
there. You could copy it from my previous comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
