scottyaslan commented on code in PR #8721:
URL: https://github.com/apache/nifi/pull/8721#discussion_r1586964545
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##########
@@ -261,56 +281,43 @@
//
// NOTE: nifi surface palette lighter/darker is purposefully omitted here.
Any application of nifi surface colors should be as a background-color to a
surface DOM element. The surface color should switch from light to dark
depending on the mode for the theme.
- .nifi-surface-default {
+ .surface-color {
color: $nifi-theme-surface-palette-default;
fill: $nifi-theme-surface-palette-default;
}
- .nifi-success-default {
+ .success-color {
color: $nifi-theme-success-palette-default;
fill: $nifi-theme-success-palette-default;
}
- .nifi-success-lighter {
+ .success-color-lighter {
color: $nifi-theme-success-palette-lighter;
fill: $nifi-theme-success-palette-lighter;
}
- .nifi-success-darker {
+ .success-color-darker {
color: $nifi-theme-success-palette-darker;
fill: $nifi-theme-success-palette-darker;
}
- .nifi-warn-default {
- color: $nifi-theme-warn-palette-default;
- fill: $nifi-theme-warn-palette-default;
+ .caution-color {
+ color: $nifi-theme-caution-palette-default;
+ fill: $nifi-theme-caution-palette-default;
Review Comment:
Pretty much any time we need a yellow color it should be the
`.caution-color`. Currently this is used extensively for any `.fa .fa-warning`
icons which are used in the `.has-errors` or `.invalid` status scenarios. The
darker caution color is used for things like back pressure, when a connection
is selected on the canvas, and midpoints, bend points, and the label resize
handle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
