Re: [PR] [NIFI-13093] use warn palette for all errors and introduce caution palette [nifi]

[via GitHub]

scottyaslan commented on PR #8721:
URL: https://github.com/apache/nifi/pull/8721#issuecomment-2090483016

   > Overall this looks great. I did find one thing that we might want to clean 
up but I'm also happy if we just want to log it and fix as part of another pull 
request...
   > 
   > Essentially, in dark mode, the checkbox we use to support select all, 
select none, or indicate some are selected isn't clearly defined when checked 
or indicating some are selected. It isn't immediately apparent that you can 
interact with it. It is fine when nothing is selected because it has an outline:
   > 
   > <img alt="Screenshot 2024-05-02 at 8 30 28 AM" width="1036" 
src="https://private-user-images.githubusercontent.com/713866/327430128-18a9644b-079e-4c17-8966-51f0fac87880.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2NTYxOTUsIm5iZiI6MTcxNDY1NTg5NSwicGF0aCI6Ii83MTM4NjYvMzI3NDMwMTI4LTE4YTk2NDRiLTA3OWUtNGMxNy04OTY2LTUxZjBmYWM4Nzg4MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwMlQxMzE4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yNDU2NjZjNTMwNmE4OWZmZDMzZDhmYTY0NzI1NzM3OGI5ZmU2MGVkZTkzYmMzNWNhYjU0ZGZhNmNkYmRmMzYzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ypA42Ik4DLHAMzsbO69Qcb93Sn0NbTRfiTRR3SWiFpI";>
 <img alt="Screenshot 2024-05-02 at 8 31 21 AM" width="1036" 
src="https://private-user-images.githubuserconte
 
nt.com/713866/327430171-dc15d0e5-74f2-486a-a370-35b57925ed02.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2NTYxOTUsIm5iZiI6MTcxNDY1NTg5NSwicGF0aCI6Ii83MTM4NjYvMzI3NDMwMTcxLWRjMTVkMGU1LTc0ZjItNDg2YS1hMzcwLTM1YjU3OTI1ZWQwMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwMlQxMzE4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNjdiYmM0MmNhZTExZDhiNGY1M2Y2MTU0Yzk1NDRlNTUyMDAwY2Y5MjRkNzI0ZjQxYmNkMzYzMDVkMzM0OTMxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.pBzeNEpPZIqFXJoJyWrzdwx23eVwZ3LMnngvxJxb3BQ">
 <img alt="Screenshot 2024-05-02 at 8 31 34 AM" width="1040" 
src="https://private-user-images.githubusercontent.com/713866/327430190-d2778102-9feb-4073-9b10-fdaafbc03bb6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3Mi
 
OiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ2NTYxOTUsIm5iZiI6MTcxNDY1NTg5NSwicGF0aCI6Ii83MTM4NjYvMzI3NDMwMTkwLWQyNzc4MTAyLTlmZWItNDA3My05YjEwLWZkYWFmYmMwM2JiNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNTAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDUwMlQxMzE4MTVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03ZDliM2MyYWNkNGI5ZmY4NjlhYWVjNDIzY2JjMTZmMTA0YzJlYjMxMzJkOWZhMzI5MmE0NzNiOWVkNWQ2ZjBhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.7XVxE_ECAQT3bBRzwjVEhbRPusDvfRY18xeoeV689J8">
   > @scottyaslan let me know if you want to include a fix for this here or if 
we should log it separately.
   
   Ooooooo good eye! Let's log it as a separate jira. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org