james94 opened a new pull request, #1775:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1775
Also kept backward compatibility for cmake FetchContent by adding two MiNiFi
CPP options: one for using CMake FetchContent and the other for using the more
faster approach conan packager to manage C++ external lib dependencies. With
conan, usually conan will install prebuilt binary conan packages from
conancenter or some other conan repo where the prebuilt binary conan packages
reside. For now, we'll stick with using conancenter as it is open source.
Verified I can run conan install command from MiNiFi root folder where
conanfile.py resides and successfully install abseil prebuilt binary conan
package for MiNiFi C++, then ran cmake generate from MiNiFi's build folder and
then started to run make. Stopped early on make since MiNiFi would try to
download and build all the remaining external lib dependencies with CMake
FetchContent since they arent managed by conan yet.
Also in Abseil.cmake's file, I added conditional statement to check if user
set the USE_CONAN_PACKAGER option or the USE_CMAKE_FETCH_CONTENT option. Will
do similar approach for the remaining external lib dependencies
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
