lordgamez commented on PR #1775: URL: https://github.com/apache/nifi-minifi-cpp/pull/1775#issuecomment-2090368183
Hi @james94, thanks for the heads up, this is great stuff you have here! Last week we actually talked about having this feature implemented as part of the 1.0.0 release, so it is awesome you've already started working on this. For the first iteration I would probably stick to having the old behaviour as the default and have a separate CI job with the `USE_CONAN_PACKAGER` variable enabled to test the build using Conan thirdparty packages. If the `USE_CONAN_PACKAGER` is `OFF` then everything would be built as it is at the moment, so probably the `USE_CMAKE_FETCH_CONTENT` wouldn't be needed. But these are just small details that can be discussed on the review after the PR is ready, can't wait to see more of it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
