[
https://issues.apache.org/jira/browse/NIFI-12973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843861#comment-17843861
]
Joe Witt commented on NIFI-12973:
---------------------------------
Specific feedback:
1. Scope. Prior to this JIRA/PR any rules established will apply to all
groups. The point of this mechanism appears to be to limit which process
groups a given defined rule applies to. If the concept in the nifi-api of a
FlowAnalysisRule is going to hold references to process groups then that should
be some collection reference to a list of identifiers or the instances of
groups themselves. It cannot be an arbitrary String which contains some
presumption of comma separation. This concept of 'scope' should likely be
renamed to 'affectedProcessGroups' or 'includedProcessGroups'.
Along with that do we have new authorization considerations to factor in? I
believe (please correct if wrong) any user that has ability to change
controller settings can create/edit flow analysis rules. So them restricting a
rule to a lesser set should not create new authorization issues to consider.
Though see commentary in 2 below.
2. User Experience: In the event they do want to scope one possible UX
direction is to let them do code-completion aided selection of Process Groups
by name/uuid showing up. As they select from that it would be added to a list
below. They should perceive they're selecting from a list of 0...n groups all
confirmed to be real/valid through code completion.
That said it seems questionable whether a user should be able to choose/select
groups a given rule applies to/does not apply to unless that user themselves
has edit access to those groups. Doing this at the controller level with no
'scoping' is one thing. But once we're letting them restrict by group then
they should have something to do/say about said group.
The UX suggested here is only effective when we're talking about small number
of selected groups.
3. What happens when a referenced process group is removed? Does the removed
group get removed from the list? I dont see where that would be occurring in
this PR. It should/can occur on startup as well as anytime a process group is
deleted through the API.
> Add Process Group scope to Flow Analysis rules
> ----------------------------------------------
>
> Key: NIFI-12973
> URL: https://issues.apache.org/jira/browse/NIFI-12973
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Pierre Villard
> Assignee: Tamas Palfy
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I think it'd be useful to have an optional property in all Flow Analysis
> rules to scope a rule execution to a specific process group (and its embedded
> process groups).
> Most NiFi users are using NiFi in a multi tenant way and are dedicating a
> process group to a given team. Different rules may apply across different
> teams hence the advantage of scoping a rule to a process group (when it makes
> sense for the rule).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
