exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2097402615
> > Thanks for proposing this new Processor @JackHintonSmartDCSIT. > > There are some coding convention details that I would highlight, but before going into those details, I first recommend moving this processor to the `nifi-network-bundle` instead of the `nifi-standard-processors` bundle. Although PCAP is a common format, this Processor seems to fit more naturally under a different bundle. > > I also recommend naming this `SplitPCAP`, following the general NiFi convention of using capital letters for acronyms in Processor class names. > > As far as the substance of the code, the relationship of the `Pcap` class to the source from the Kaitai Project was not quite clear. Do you have a source code reference as well as the general PCAP page listed in the NOTICE file? > > I would also be interested in feedback from another project contributor about the maintainability of this Processor, as we want to avoid bringing in components that might not be actively maintained. > > @exceptionfactory My team would certainly be interested in this processor as we have our own custom processor but not with the use of kaitai. I am trying to better understand how kaitai works. Thanks for the comments @dan-s1, that is helpful. As noted in the initial review, there are a number of coding convention concerns, along with the location of this Processor in the standard-nar. It should be possible to address those and move this forward, and it looks like there are no dependencies on the Kaitai project, which is useful. I will be glad to give this a closer review after our initial comments have been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
