dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1596969674


##########
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/util/PCAP.java:
##########
@@ -0,0 +1,717 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to 
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in 
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN 
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.util;
+
+import java.nio.ByteBuffer;
+import java.nio.ByteOrder;
+import java.util.Map;
+
+import org.apache.commons.lang3.EnumUtils;
+
+import java.util.HashMap;
+import java.util.ListIterator;
+import java.util.ArrayList;
+
+/**
+ * PCAP (named after libpcap / winpcap) is a popular format for saving
+ * network traffic grabbed by network sniffers. It is typically
+ * produced by tools like [tcpdump](https://www.tcpdump.org/) or
+ * [Wireshark](https://www.wireshark.org/).
+ *
+ * @see <a href=
+ *      "https://wiki.wireshark.org/Development/LibpcapFileFormat";>Source</a>
+ */
+public class PCAP {
+    public ByteBufferInterface io;
+
+    public enum Linktype {
+        NULL_LINKTYPE(0),
+        ETHERNET(1),
+        EXP_ETHERNET(2),
+        AX25(3),
+        PRONET(4),
+        CHAOS(5),
+        IEEE802_5(6),
+        ARCNET_BSD(7),
+        SLIP(8),
+        PPP(9),
+        FDDI(10),
+        REDBACK_SMARTEDGE(32),
+        PPP_HDLC(50),
+        PPP_ETHER(51),
+        SYMANTEC_FIREWALL(99),
+        ATM_RFC1483(100),
+        RAW(101),
+        C_HDLC(104),
+        IEEE802_11(105),
+        ATM_CLIP(106),
+        FRELAY(107),
+        LOOP(108),
+        ENC(109),
+        NETBSD_HDLC(112),
+        LINUX_SLL(113),
+        LTALK(114),
+        ECONET(115),
+        IPFILTER(116),
+        PFLOG(117),
+        CISCO_IOS(118),
+        IEEE802_11_PRISM(119),
+        AIRONET_HEADER(120),
+        IP_OVER_FC(122),
+        SUNATM(123),
+        RIO(124),
+        PCI_EXP(125),
+        AURORA(126),
+        IEEE802_11_RADIOTAP(127),
+        TZSP(128),
+        ARCNET_LINUX(129),
+        JUNIPER_MLPPP(130),
+        JUNIPER_MLFR(131),
+        JUNIPER_ES(132),
+        JUNIPER_GGSN(133),
+        JUNIPER_MFR(134),
+        JUNIPER_ATM2(135),
+        JUNIPER_SERVICES(136),
+        JUNIPER_ATM1(137),
+        APPLE_IP_OVER_IEEE1394(138),
+        MTP2_WITH_PHDR(139),
+        MTP2(140),
+        MTP3(141),
+        SCCP(142),
+        DOCSIS(143),
+        LINUX_IRDA(144),
+        IBM_SP(145),
+        IBM_SN(146),
+        USER0(147),
+        USER1(148),
+        USER2(149),
+        USER3(150),
+        USER4(151),
+        USER5(152),
+        USER6(153),
+        USER7(154),
+        USER8(155),
+        USER9(156),
+        USER10(157),
+        USER11(158),
+        USER12(159),
+        USER13(160),
+        USER14(161),
+        USER15(162),
+        IEEE802_11_AVS(163),
+        JUNIPER_MONITOR(164),
+        BACNET_MS_TP(165),
+        PPP_PPPD(166),
+        JUNIPER_PPPOE(167),
+        JUNIPER_PPPOE_ATM(168),
+        GPRS_LLC(169),
+        GPF_T(170),
+        GPF_F(171),
+        GCOM_T1E1(172),
+        GCOM_SERIAL(173),
+        JUNIPER_PIC_PEER(174),
+        ERF_ETH(175),
+        ERF_POS(176),
+        LINUX_LAPD(177),
+        JUNIPER_ETHER(178),
+        JUNIPER_PPP(179),
+        JUNIPER_FRELAY(180),
+        JUNIPER_CHDLC(181),
+        MFR(182),
+        JUNIPER_VP(183),
+        A429(184),
+        A653_ICM(185),
+        USB_FREEBSD(186),
+        BLUETOOTH_HCI_H4(187),
+        IEEE802_16_MAC_CPS(188),
+        USB_LINUX(189),
+        CAN20B(190),
+        IEEE802_15_4_LINUX(191),
+        PPI(192),
+        IEEE802_16_MAC_CPS_RADIO(193),
+        JUNIPER_ISM(194),
+        IEEE802_15_4_WITHFCS(195),
+        SITA(196),
+        ERF(197),
+        RAIF1(198),
+        IPMB_KONTRON(199),
+        JUNIPER_ST(200),
+        BLUETOOTH_HCI_H4_WITH_PHDR(201),
+        AX25_KISS(202),
+        LAPD(203),
+        PPP_WITH_DIR(204),
+        C_HDLC_WITH_DIR(205),
+        FRELAY_WITH_DIR(206),
+        LAPB_WITH_DIR(207),
+        IPMB_LINUX(209),
+        FLEXRAY(210),
+        MOST(211),
+        LIN(212),
+        X2E_SERIAL(213),
+        X2E_XORAYA(214),
+        IEEE802_15_4_NONASK_PHY(215),
+        LINUX_EVDEV(216),
+        GSMTAP_UM(217),
+        GSMTAP_ABIS(218),
+        MPLS(219),
+        USB_LINUX_MMAPPED(220),
+        DECT(221),
+        AOS(222),
+        WIHART(223),
+        FC_2(224),
+        FC_2_WITH_FRAME_DELIMS(225),
+        IPNET(226),
+        CAN_SOCKETCAN(227),
+        IPV4(228),
+        IPV6(229),
+        IEEE802_15_4_NOFCS(230),
+        DBUS(231),
+        JUNIPER_VS(232),
+        JUNIPER_SRX_E2E(233),
+        JUNIPER_FIBRECHANNEL(234),
+        DVB_CI(235),
+        MUX27010(236),
+        STANAG_5066_D_PDU(237),
+        JUNIPER_ATM_CEMIC(238),
+        NFLOG(239),
+        NETANALYZER(240),
+        NETANALYZER_TRANSPARENT(241),
+        IPOIB(242),
+        MPEG_2_TS(243),
+        NG40(244),
+        NFC_LLCP(245),
+        PFSYNC(246),
+        INFINIBAND(247),
+        SCTP(248),
+        USBPCAP(249),
+        RTAC_SERIAL(250),
+        BLUETOOTH_LE_LL(251),
+        WIRESHARK_UPPER_PDU(252),
+        NETLINK(253),
+        BLUETOOTH_LINUX_MONITOR(254),
+        BLUETOOTH_BREDR_BB(255),
+        BLUETOOTH_LE_LL_WITH_PHDR(256),
+        PROFIBUS_DL(257),
+        PKTAP(258),
+        EPON(259),
+        IPMI_HPM_2(260),
+        ZWAVE_R1_R2(261),
+        ZWAVE_R3(262),
+        WATTSTOPPER_DLM(263),
+        ISO_14443(264),
+        RDS(265),
+        USB_DARWIN(266),
+        OPENFLOW(267),
+        SDLC(268),
+        TI_LLN_SNIFFER(269),
+        LORATAP(270),
+        VSOCK(271),
+        NORDIC_BLE(272),
+        DOCSIS31_XRA31(273),
+        ETHERNET_MPACKET(274),
+        DISPLAYPORT_AUX(275),
+        LINUX_SLL2(276),
+        SERCOS_MONITOR(277),
+        OPENVIZSLA(278),
+        EBHSCR(279),
+        VPP_DISPATCH(280),
+        DSA_TAG_BRCM(281),
+        DSA_TAG_BRCM_PREPEND(282),
+        IEEE802_15_4_TAP(283),
+        DSA_TAG_DSA(284),
+        DSA_TAG_EDSA(285),
+        ELEE(286),
+        ZWAVE_SERIAL(287),
+        USB_2_0(288),
+        ATSC_ALP(289),
+        ETW(290),
+        NETANALYZER_NG(291),
+        ZBOSS_NCP(292),
+        USB_2_0_LOW_SPEED(293),
+        USB_2_0_FULL_SPEED(294),
+        USB_2_0_HIGH_SPEED(295),
+        AUERSWALD_LOG(296),
+        ZWAVE_TAP(297),
+        SILABS_DEBUG_CHANNEL(298),
+        FIRA_UCI(299);
+
+        private final long id;
+
+        Linktype(long id) {
+            this.id = id;
+        }
+
+        public long id() {
+            return id;
+        }
+
+        private static final Map<Long, Linktype> byId = new HashMap<Long, 
Linktype>(209);
+        static {
+            for (Linktype e : Linktype.values())
+                byId.put(e.id(), e);
+        }
+
+        public static Linktype byId(long id) {
+            return byId.get(id);
+        }
+    }
+
+    public PCAP(ByteBufferInterface io) {
+        this(io, null, null);
+    }
+
+    public PCAP(ByteBufferInterface io, Object parent) {
+        this(io, parent, null);
+    }
+
+    public PCAP(ByteBufferInterface io, Object parent, PCAP root) {
+
+        this.parent = parent;
+        this.root = root == null ? this : root;
+        this.io = io;
+        read();
+    }
+
+    public PCAP(Header hdr, ArrayList<Packet> packets) {
+        this.hdr = hdr;
+        this.packets = packets;
+    }
+
+    public byte[] readBytesFull() {
+
+        int headerBufferSize = 20 + this.hdr().magicNumber().length;
+        ByteBuffer headerBuffer = ByteBuffer.allocate(headerBufferSize);
+        headerBuffer.order(ByteOrder.LITTLE_ENDIAN);
+
+        headerBuffer.put(this.hdr().magicNumber());
+        headerBuffer.put(this.readIntToNBytes(this.hdr().versionMajor(), 2, 
false));
+        headerBuffer.put(this.readIntToNBytes(this.hdr().versionMinor(), 2, 
false));
+        headerBuffer.put(this.readIntToNBytes(this.hdr().thiszone(), 4, 
false));
+        headerBuffer.put(this.readLongToNBytes(this.hdr().sigfigs(), 4, true));
+        headerBuffer.put(this.readLongToNBytes(this.hdr().snaplen(), 4, true));
+        headerBuffer.put(this.readLongToNBytes(this.hdr().network().id, 4, 
true));
+
+        ArrayList<byte[]> packetByteArrays = new ArrayList<byte[]>();
+
+        ListIterator<Packet> packetsIterator = packets.listIterator();
+
+        int packetBufferSize = 0;
+
+        for (int loop = 0; loop < packets.size(); loop++) {
+            Packet currentPacket = packetsIterator.next();
+            ByteBuffer currentPacketBytes = ByteBuffer.allocate(16 + 
currentPacket.raw_body().length);
+            currentPacketBytes.put(readLongToNBytes(currentPacket.tsSec, 4, 
false));
+            currentPacketBytes.put(readLongToNBytes(currentPacket.tsUsec, 4, 
false));
+            currentPacketBytes.put(readLongToNBytes(currentPacket.inclLen, 4, 
false));
+            currentPacketBytes.put(readLongToNBytes(currentPacket.origLen, 4, 
false));
+            currentPacketBytes.put(currentPacket.raw_body());
+
+            packetByteArrays.add(currentPacketBytes.array());
+            packetBufferSize += 16 + currentPacket.raw_body().length;
+        }
+
+        ByteBuffer packetBuffer = ByteBuffer.allocate(packetBufferSize);
+        packetBuffer.order(ByteOrder.LITTLE_ENDIAN);
+
+        for (int loop = 0; loop < packetByteArrays.size(); loop++) {
+            packetBuffer.put(packetByteArrays.get(loop));
+        }
+
+        ByteBuffer allBytes = ByteBuffer.allocate(headerBufferSize + 
packetBufferSize);
+        allBytes.order(ByteOrder.LITTLE_ENDIAN);
+
+        allBytes.put(headerBuffer.array());
+        allBytes.put(packetBuffer.array());
+
+        return allBytes.array();
+    }
+
+    private byte[] readIntToNBytes(int input, int number_of_bytes, boolean 
isSigned) {
+        byte[] output = new byte[number_of_bytes];
+        output[0] = (byte) (input & 0xff);
+        for (int loop = 1; loop < number_of_bytes; loop++) {
+            if (isSigned) {
+                output[loop] = (byte) (input >> (8 * loop));
+            } else {
+                output[loop] = (byte) (input >>> (8 * loop));
+            }
+        }
+        return output;
+    }
+
+    private byte[] readLongToNBytes(long input, int number_of_bytes, boolean 
isSigned) {
+        byte[] output = new byte[number_of_bytes];
+        output[0] = (byte) (input & 0xff);
+        for (int loop = 1; loop < number_of_bytes; loop++) {
+            if (isSigned) {
+                output[loop] = (byte) (input >> (8 * loop));
+            } else {
+                output[loop] = (byte) (input >>> (8 * loop));
+            }
+        }
+        return output;
+    }
+
+    private void read() {
+        this.hdr = new Header(this.io, this, root);
+        this.packets = new ArrayList<Packet>();
+        {
+            while (!this.io.isEof()) {
+                this.packets.add(new Packet(this.io, this, root));
+            }
+        }
+    }
+
+    public static class ByteBufferInterface {
+
+        public ByteBufferInterface(ByteBuffer buffer) {
+            this.buffer = buffer;
+        }
+
+        public ByteBufferInterface(byte[] byteArray) {
+            this.buffer = ByteBuffer.wrap(byteArray);
+        }
+
+        public static class ValidationNotEqualError extends Exception {
+            public ValidationNotEqualError(String message) {
+                super(message);
+            }
+        }
+
+        public ByteBuffer buffer;
+
+        public int readU2be() {
+            buffer.order(ByteOrder.BIG_ENDIAN);
+            return (buffer.getShort() & 0xffff);
+        }
+
+        public int readU2le() {
+            buffer.order(ByteOrder.LITTLE_ENDIAN);
+            return (buffer.getShort() & 0xffff);
+        }
+
+        public long readU4be() {
+            buffer.order(ByteOrder.BIG_ENDIAN);
+            return ((long) buffer.getInt() & 0xffffffffL);
+        }
+
+        public long readU4le() {
+            buffer.order(ByteOrder.LITTLE_ENDIAN);
+            return ((long) buffer.getInt() & 0xffffffffL);
+        }
+
+        public int readS4be() {
+            buffer.order(ByteOrder.BIG_ENDIAN);
+            return buffer.getInt();
+        }
+
+        public int readS4le() {
+            buffer.order(ByteOrder.LITTLE_ENDIAN);
+            return buffer.getInt();
+        }
+
+        public byte[] readBytes(int n) {
+            byte[] output = new byte[n];
+            buffer.get(output);
+            return output;
+        }
+
+        public byte[] readBytes(long n) {
+            byte[] output = new byte[(int) n];
+            buffer.get(output);
+            return output;
+        }
+
+        public boolean isEof() {
+            return !buffer.hasRemaining();
+        }
+    }
+
+    /**
+     * @see <a href=
+     *      
"https://wiki.wireshark.org/Development/LibpcapFileFormat#Global_Header";>Source</a>
+     */
+    public static class Header {
+        public ByteBufferInterface io;
+
+        public Header(ByteBufferInterface io) {
+            this(io, null, null);
+        }
+
+        public Header(ByteBufferInterface io, PCAP parent) {
+            this(io, parent, null);
+        }
+
+        public Header(ByteBufferInterface io, PCAP parent, PCAP root) {
+
+            this.parent = parent;
+            this.root = root;
+            this.io = io;
+            try {
+                read();
+            } catch 
(org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface.ValidationNotEqualError
 e) {
+                e.printStackTrace();
+            }
+        }
+
+        public Header(byte[] magicNumber, int versionMajor, int versionMinor, 
int thiszone, long sigfigs, long snaplen,
+                String network) {
+
+            Linktype networkEnum = Linktype.RAW;
+            if (EnumUtils.isValidEnum(Linktype.class, network)) {
+                networkEnum = Linktype.valueOf(network);
+            }
+
+            this.magicNumber = magicNumber;
+            this.versionMajor = versionMajor;
+            this.versionMinor = versionMinor;
+            this.thiszone = thiszone;
+            this.sigfigs = sigfigs;
+            this.snaplen = snaplen;
+            this.network = networkEnum;
+        }
+
+        public ByteBufferInterface io() {
+            return io;
+        }
+
+        private void read()
+                throws 
org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface.ValidationNotEqualError
 {
+            this.magicNumber = this.io.readBytes(4);
+            if (this.magicNumber == new byte[] { (byte) 0xd4, (byte) 0xc3, 
(byte) 0xb2, (byte) 0xa1 }) {
+                // have to swap the bits
+                this.versionMajor = this.io.readU2be();
+                if (!(versionMajor() == 2)) {
+
+                    throw new 
ByteBufferInterface.ValidationNotEqualError("Packet major version is not 2.");
+                }
+                this.versionMinor = this.io.readU2be();
+                this.thiszone = this.io.readS4be();
+                this.sigfigs = this.io.readU4be();
+                this.snaplen = this.io.readU4be();
+                this.network = PCAP.Linktype.byId(this.io.readU4be());
+            } else {
+                this.versionMajor = this.io.readU2le();
+                if (!(versionMajor() == 2)) {
+                    throw new 
ByteBufferInterface.ValidationNotEqualError("Packet major version is not 2.");
+                }
+                this.versionMinor = this.io.readU2le();
+                this.thiszone = this.io.readS4le();
+                this.sigfigs = this.io.readU4le();
+                this.snaplen = this.io.readU4le();
+                this.network = PCAP.Linktype.byId(this.io.readU4le());
+            }
+        }
+
+        private byte[] magicNumber;
+        private int versionMajor;
+        private int versionMinor;
+        private int thiszone;
+        private long sigfigs;
+        private long snaplen;
+        private Linktype network;
+        private PCAP root;
+        private PCAP parent;
+
+        public byte[] magicNumber() {
+            return magicNumber;
+        }
+
+        public int versionMajor() {
+            return versionMajor;
+        }
+
+        public int versionMinor() {
+            return versionMinor;
+        }
+
+        /**
+         * Correction time in seconds between UTC and the local
+         * timezone of the following packet header timestamps.
+         */
+        public int thiszone() {
+            return thiszone;
+        }
+
+        /**
+         * In theory, the accuracy of time stamps in the capture; in
+         * practice, all tools set it to 0.
+         */
+        public long sigfigs() {
+            return sigfigs;
+        }
+
+        /**
+         * The "snapshot length" for the capture (typically 65535 or
+         * even more, but might be limited by the user), see: incl_len
+         * vs. orig_len.
+         */
+        public long snaplen() {
+            return snaplen;
+        }
+
+        /**
+         * Link-layer header type, specifying the type of headers at
+         * the beginning of the packet.
+         */
+        public Linktype network() {
+            return network;
+        }
+
+        public PCAP root() {
+            return root;
+        }
+
+        public PCAP parent() {
+            return parent;
+        }
+    }
+
+    /**
+     * @see <a href=
+     *      
"https://wiki.wireshark.org/Development/LibpcapFileFormat#Record_.28Packet.29_Header";>Source</a>
+     */
+    public static class Packet {
+        public ByteBufferInterface io;
+
+        public Packet(ByteBufferInterface io) {
+            this(io, null, null);
+        }
+
+        public Packet(ByteBufferInterface io, PCAP parent) {
+            this(io, parent, null);
+        }
+
+        public Packet(ByteBufferInterface io, PCAP parent, PCAP root) {
+
+            this.parent = parent;
+            this.root = root;
+            this.io = io;
+            read();
+        }
+
+        public Packet(long tSSec, long tSUsec, long inclLen, long origLen, 
byte[] rawBody, String network) {
+
+            this.tsSec = tSSec;
+            this.tsUsec = tSUsec;
+            this.inclLen = inclLen;
+            this.origLen = origLen;
+            this.raw_body = rawBody;
+        }
+
+        private void read() {
+            this.tsSec = this.io.readU4le();
+            this.tsUsec = this.io.readU4le();
+            this.inclLen = this.io.readU4le();
+            this.origLen = this.io.readU4le();
+            {
+                Linktype on = root().hdr().network();
+                if (on != null) {
+                    switch (root().hdr().network()) {
+                        case PPI: {
+                            this.raw_body = this.io.readBytes(
+                                    (inclLen() < root().hdr().snaplen() ? 
inclLen() : root().hdr().snaplen()));
+                            break;
+                        }
+                        case ETHERNET: {
+                            this.raw_body = this.io.readBytes(
+                                    (inclLen() < root().hdr().snaplen() ? 
inclLen() : root().hdr().snaplen()));
+                            break;
+                        }

Review Comment:
   Intellij noted these are duplicate branches so they should be combined. In 
addition it suggested using `Math.min` instead of the tertiary operator.
   ```suggestion
                          case PPI, ETHERNET: {
                               this.raw_body = this.io.readBytes(
                                       (Math.min(inclLen(), 
root().hdr().snaplen())));
                               break;
                           }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to