mcgilman commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1597059242
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html:
##########
@@ -17,7 +17,7 @@
<div class="provenance-event-table h-full flex flex-col gap-y-2">
<error-banner></error-banner>
- <div [class.hidden]="showLineage" class="h-full flex flex-col gap-y-2">
+ <div [class.hidden]="showLineage" class="h-full flex flex-col">
Review Comment:
This change makes the filter controls too close to the table when compared
to other tables with filter controls.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/feature/access-policies.component.html:
##########
@@ -15,14 +15,14 @@
~ limitations under the License.
-->
-<div class="pb-5 flex flex-col h-screen justify-between gap-y-5">
- <header class="nifi-header">
+<div class="flex flex-col h-screen justify-between">
+ <header class="pb-5 nifi-header">
<navigation></navigation>
</header>
<div class="px-5">
- <h3 class="primary-color">Access Policies</h3>
+ <h3 class="pb-5 primary-color">Access Policies</h3>
</div>
- <div class="px-5 flex-1">
+ <div class="pb-5 px-5 flex-1">
<router-outlet></router-outlet>
</div>
</div>
Review Comment:
What are these changes doing? It looks like it would result in the same
layout without them.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html:
##########
@@ -17,7 +17,7 @@
<div class="provenance-event-table h-full flex flex-col gap-y-2">
<error-banner></error-banner>
- <div [class.hidden]="showLineage" class="h-full flex flex-col gap-y-2">
+ <div [class.hidden]="showLineage" class="h-full flex flex-col">
Review Comment:
It also makes the refresh control at the bottom of the table too close.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/global-access-policies/global-access-policies.component.html:
##########
@@ -22,7 +22,7 @@
</div>
} @else {
@if (flowConfiguration$ | async; as flowConfiguration) {
- <div class="global-access-policies flex flex-col h-full gap-y-2">
+ <div class="global-access-policies flex flex-col h-full">
Review Comment:
This change looks a little crowded when an error occurs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
