scottyaslan commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1598830962
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/provenance/ui/provenance-event-listing/provenance-event-table/provenance-event-table.component.html:
##########
@@ -17,7 +17,7 @@
<div class="provenance-event-table h-full flex flex-col gap-y-2">
<error-banner></error-banner>
- <div [class.hidden]="showLineage" class="h-full flex flex-col gap-y-2">
+ <div [class.hidden]="showLineage" class="h-full flex flex-col">
Review Comment:
This is also an issue throughout the app. For all `mat-form-field`'s like
this angular adds a bottom margin for the `mat-hint` or `mat-error`. However,
in these usages of `mat-form-field` above tables throughout nifi we do not
follow the material spec and instead we place the hint above the fields.
In order to address this issue I see two options:
1. We can update the UX to follow the material specification and leverage
the `mat-hint`.
OR
2. We need to remove the margin at the bottom of these fields ( I think we
can leverage
https://material.angular.io/components/form-field/api#SubscriptSizing) and then
also go through and update the spacing/padding of these form fields table
filters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
