james94 opened a new pull request, #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793

   Verified I can Install & Build MiNiFi w OpenSSL, CURL, ZLIB using conan, 
then I set the MINIFI_HOME environment variable & ran minifi binary executable.
   
   Will add the steps to reproduce (later we can integrate conan into the 
python bootstrap, the goal was to introduce you guys to the conan build 
approach with minimal changes): @lordgamez @szaszm
   
   ~~~bash
   # make sure to install conan2 for your environment
   sudo pip install --force-reinstall -v "conan==2.3.1"
   
   # conanfile.py is in root dir of MiNiFi C++ project
   cd $HOME/nifi-minifi-cpp
   
   # create MINIFI_HOME env variable for binary executable minifi
   export MINIFI_HOME=$(pwd)
   
   # In case you need to delete all conan packages
   # conan remove "*" -c
   
   # install conan packages for MiNiFi C++ using conanfile.py invoking Conan
   conan install . --build=missing --output-folder=build_conan 
-pr=$HOME/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
   
   # build MiNiFi C++ using conanfile.py invoking Conan & CMake
   conan build . --output-folder=build_conan 
-pr=$HOME/nifi-minifi-cpp/etc/build/conan/profiles/release-linux
   
   # verify we can run minifi binary executable
   ./build_conan/bin/minifi
   ~~~
   
   
   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically main)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the LICENSE file?
   - [ ] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI 
results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to