james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1609216217
########## cmake/BundledZLIB.cmake: ########## @@ -18,56 +18,65 @@ function(use_bundled_zlib SOURCE_DIR BINARY_DIR) Review Comment: I incorporated your feedback into commit [cf2face](https://github.com/apache/nifi-minifi-cpp/pull/1793/commits/cf2facee3a1ecc2909d439a4fe9cd1ca60830617) I do like your suggestion, it makes the MiNiFi CMake code look cleaner with the conan v2.3.1 integration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
