joewitt commented on code in PR #8863:
URL: https://github.com/apache/nifi/pull/8863#discussion_r1609988737


##########
nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-services-api/pom.xml:
##########
@@ -31,5 +31,23 @@
             <groupId>com.google.auth</groupId>
             <artifactId>google-auth-library-oauth2-http</artifactId>
         </dependency>
+        <!-- please do not remove grpc-* dependencies because they are used by 
GCP processors at runtime,
+             see also 
https://github.com/apache/nifi/pull/8491#issuecomment-1992542785 -->
+        <dependency>
+            <groupId>io.grpc</groupId>
+            <artifactId>grpc-api</artifactId>

Review Comment:
   scope for these four should be 'runtime' if they're not necessary for 
compile but needed for tests/execution and makes their necessity explicit.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to