scottyaslan commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612046025
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##########
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
- request: {
- id: processorId,
- uri: request.uri,
- type: request.type,
- payload:
updateProcessorRequest.payload,
- errorStrategy: 'banner',
- postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
- }
+ request: updateProcessorRequest
})
);
});
Review Comment:
Something strange is happening to the browser history when the browser
forward/back navigation is used to close a dialog:
Here is another example:
This behavior is present on master so it is not related to this PR. We
should file another jira to address this. We need to add handling for the
browser forward/backward close dialog navigation as well as handling the 'Esc'
button to close the dialog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
