mcgilman commented on code in PR #8859:
URL: https://github.com/apache/nifi/pull/8859#discussion_r1612409434
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts:
##########
@@ -1392,14 +1478,7 @@ export class FlowEffects {
.subscribe((updateProcessorRequest:
UpdateProcessorRequest) => {
this.store.dispatch(
FlowActions.updateProcessor({
- request: {
- id: processorId,
- uri: request.uri,
- type: request.type,
- payload:
updateProcessorRequest.payload,
- errorStrategy: 'banner',
- postUpdateNavigation:
updateProcessorRequest.postUpdateNavigation
- }
+ request: updateProcessorRequest
})
);
});
Review Comment:
@scottyaslan Thanks for filing the JIRA. Agreed that is an issue with our
dialog close handling when the user navigates forward/back with their browsers.
The other scenario looks like a bug in the logic when a new back navigation is
pushed that is introduced in this PR. I think simply avoid pushing a duplicate
back navigation would address this case. Great idea. Let me prep another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
