bbende commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1619117358
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##########
@@ -2057,6 +2062,100 @@ public Response getDetails(
return generateOkResponse(flowDetails).build();
}
+ @GET
+ @Consumes(MediaType.WILDCARD)
+ @Produces(MediaType.APPLICATION_JSON)
+
@Path("registries/{registry-id}/branches/{branch-id-a}/buckets/{bucket-id-a}/flows/{flow-id-a}/{version-a}/diff/branches/{branch-id-b}/buckets/{bucket-id-b}/flows/{flow-id-b}/{version-b}")
Review Comment:
Is the intended use case for this to right-click on a process group under
version control and be able to choose something like `Compare With` and then
choose another version to compare with? is there any other scenario where we
want to compare two flow versions?
I'm asking because if it is limited to the first scenario I described, we
may want to consider a more specific API to the PG, similar to
`process-groups/{id}/local-changes`, maybe `/process-groups/{id}/diff`. Then it
would only need the parameters for the other flow version to compare to, which
could be added to the path, or as query params.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
