simonbence commented on code in PR #8670:
URL: https://github.com/apache/nifi/pull/8670#discussion_r1624142337
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/FlowResource.java:
##########
@@ -2057,6 +2062,100 @@ public Response getDetails(
return generateOkResponse(flowDetails).build();
}
+ @GET
+ @Consumes(MediaType.WILDCARD)
+ @Produces(MediaType.APPLICATION_JSON)
+
@Path("registries/{registry-id}/branches/{branch-id-a}/buckets/{bucket-id-a}/flows/{flow-id-a}/{version-a}/diff/branches/{branch-id-b}/buckets/{bucket-id-b}/flows/{flow-id-b}/{version-b}")
Review Comment:
The main use case is to provide a possibility to make comparisons even
_before_ picking a version. As for the user's perspective this will result a
similar listing as we have with `Local changes`. The intended place for this is
the version list (for example when exeucting `Change Version` action on a
versioned group as an addition.
The URL deliberately consists this many parameteres: the simplest situation
is where we want to compers consecurtive versions of the same flow (in the same
branch, etc.). A more complex, but still useful scenario is to compare flow
snapshots between branches, like between a production and a development branch.
As the branching strategy does not provide rescritions to follow the same
structure for every branch, stricting this might make it impossible to make
useful comparions with certain setups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
