[
https://issues.apache.org/jira/browse/NIFI-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15800259#comment-15800259
]
ASF GitHub Bot commented on NIFI-3004:
--------------------------------------
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/1375
@pvillard31 I added some logic to handle repeated invocations of the
`customValidate` method and expire the results after 5 invocations even if the
properties had not changed (added unit test demonstrating that if the keystore
file is modified on the filesystem, `customValidate` will incorrectly report
the service is valid as an example).
Please review my changes
[here](https://github.com/apache/nifi/compare/master...alopresto:NIFI-3004) and
provide feedback, potentially incorporating them into your PR if you agree.
Thanks.
> Improve StandardSSLContextService customValidate
> ------------------------------------------------
>
> Key: NIFI-3004
> URL: https://issues.apache.org/jira/browse/NIFI-3004
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Michael Moser
> Assignee: Pierre Villard
> Priority: Minor
> Labels: newbie
>
> The StandardSSLContextService customValidate() method can be called many
> times in one validation cycle, so it must be efficient. Currently, it calls
> validateStore() on keystore and truststore, which opens each file and
> verifies it can be read and the password is correct. If that works then it
> calls verifySslConfig() which creates 3 sample SSLContext objects.
> Improve this by remembering when customValidate() has been successful and
> avoiding doing another full validation either for a very small amount of time
> or until one of the Property values changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
