[
https://issues.apache.org/jira/browse/NIFI-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801313#comment-15801313
]
ASF GitHub Bot commented on NIFI-3004:
--------------------------------------
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1375
Hey @alopresto, thanks for the review! I added your work as an additional
commit to this PR. It looks good to me. Maybe the threshold could be added as a
controller service property (however it could sound like a strange property to
users not aware of the internal validation process), but I agree that it seems
like a fine value as-is.
> Improve StandardSSLContextService customValidate
> ------------------------------------------------
>
> Key: NIFI-3004
> URL: https://issues.apache.org/jira/browse/NIFI-3004
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Michael Moser
> Assignee: Pierre Villard
> Priority: Minor
> Labels: newbie
>
> The StandardSSLContextService customValidate() method can be called many
> times in one validation cycle, so it must be efficient. Currently, it calls
> validateStore() on keystore and truststore, which opens each file and
> verifies it can be read and the password is correct. If that works then it
> calls verifySslConfig() which creates 3 sample SSLContext objects.
> Improve this by remembering when customValidate() has been successful and
> avoiding doing another full validation either for a very small amount of time
> or until one of the Property values changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
