sullis commented on code in PR #8969:
URL: https://github.com/apache/nifi/pull/8969#discussion_r1641609185
##########
nifi-extension-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/EventLoopGroupFactory.java:
##########
@@ -35,6 +34,16 @@ class EventLoopGroupFactory {
private int workerThreads;
+ private NettyTransports.NettyTransport nettyTransport;
+
+ public EventLoopGroupFactory() {
+ this(NettyTransports.getDefaultNettyTransport());
+ }
+
+ public EventLoopGroupFactory(NettyTransports.NettyTransport
nettyTransport) {
+ this.nettyTransport = nettyTransport;
+ }
Review Comment:
Agreed. I'll remove the parameterized constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]