sullis commented on PR #8969: URL: https://github.com/apache/nifi/pull/8969#issuecomment-2174849271
> Thanks for making the adjustments @sullis, the changes look good. > > On subsequent review, it seems like it would be helpful to change the `NettyTransport` from a `record` to an `enum`, which would remove the need for the separate string `name` property, and also make it easier to compare expected values in the test classes. Ack. I converted 'NettyTransports' to a Java enum ``` public enum NettyTransport ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
