mcgilman commented on code in PR #8965:
URL: https://github.com/apache/nifi/pull/8965#discussion_r1663146348
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.html:
##########
@@ -173,6 +173,12 @@
Manage Access Policies
</button>
}
+ @if (canConfigure(item)) {
+ <button mat-menu-item
(click)="moveClicked(item)">
+ <i class="fa fa-arrows primary-color
mr-2"></i>
+ Move
+ </button>
+ }
Review Comment:
Thanks for the update here. The new `Input()` supports function that returns
whether the service can be moved. However, the implements are not service
specific and always just return `true` or `false`. Can this `Input()` be
simplified into a boolean?
`@Input() canMove: boolean = false;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
