mcgilman commented on code in PR #8965:
URL: https://github.com/apache/nifi/pull/8965#discussion_r1663167110
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts:
##########
@@ -635,6 +636,82 @@ export class ControllerServicesEffects {
{ dispatch: false }
);
+ openMoveControllerServiceDialog$ = createEffect(
+ () =>
+ this.actions$.pipe(
+
ofType(ControllerServicesActions.openMoveControllerServiceDialog),
+ map((action) => action.request),
+ concatLatestFrom(() =>
this.store.select(selectCurrentProcessGroupId)),
+ tap(([request, currentProcessGroupId]) => {
+ const serviceId: string = request.id;
+ request.processGroupFlow =
this.flowService.getFlow(currentProcessGroupId);
Review Comment:
Ah sorry. Yes you are correct. I thought we had stashed the entire
`processGroupFlow` in the service state as well but I see that only saved the
breadcrumbs and parameter context details. Now we're saving the entire
`processGroupFlow` next to the breadcrumbs and parameter context details.
Do we only need the `processGroupFlow` in order to get the child Process
Groups for the Move dialog? If so, what are your thoughts only saving them in
the store. Often times the flow can be very large and in this page we won't
need most of those details.
Let me know if I missed something and we do need additional details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
