szaszm commented on code in PR #1834:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1834#discussion_r1672020426
##########
bootstrap.sh:
##########
@@ -246,6 +246,16 @@ if [ -z "${CMAKE_COMMAND}" ] ||
get_cmake_version
fi
+# RHEL8: If cmake3 is too old, try cmake
+if [ "$CMAKE_COMMAND" = "cmake3" ] &&
+ [ "$CMAKE_MAJOR" -lt "$CMAKE_GLOBAL_MIN_VERSION_MAJOR" ] ||
+ [ "$CMAKE_MINOR" -lt "$CMAKE_GLOBAL_MIN_VERSION_MINOR" ] ||
+ [ "$CMAKE_REVISION" -lt "$CMAKE_GLOBAL_MIN_VERSION_REVISION" ] &&
Review Comment:
both should be fixed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]