fgerlits commented on code in PR #1834:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1834#discussion_r1672099305


##########
bstrp_functions.sh:
##########
@@ -26,6 +26,24 @@ get_cmake_version(){
   CMAKE_REVISION=$(echo "$CMAKE_VERSION" | cut -d. -f3)
 }
 
+# Checks if a version is smaller than another
+compare_version() {

Review Comment:
   I think something like `version_is_less_than` would be better than 
`compare_version`



##########
bstrp_functions.sh:
##########
@@ -457,3 +475,5 @@ read_feature_options(){
     *) echo -e "${RED}Please enter an option A-Z or AA-AF or 
1-7...${NO_COLOR}" && sleep 2
   esac
 }
+
+# vim: shiftwidth=2 tabstop=2 expandtab

Review Comment:
   did you add these vim-specific comments intentionally?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to