exceptionfactory commented on code in PR #9145:
URL: https://github.com/apache/nifi/pull/9145#discussion_r1720787739


##########
nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-common/pom.xml:
##########
@@ -86,6 +89,21 @@
             <artifactId>iceberg-orc</artifactId>
             <version>${iceberg.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.iceberg</groupId>
+            <artifactId>iceberg-aws</artifactId>
+            <version>${iceberg.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.iceberg</groupId>
+            <artifactId>iceberg-azure</artifactId>
+            <version>${iceberg.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.iceberg</groupId>
+            <artifactId>iceberg-gcp</artifactId>
+            <version>${iceberg.version}</version>
+        </dependency>

Review Comment:
   @mark-bathori Are these additional dependencies required as part of this 
change? They appear to be unrelated, and introduce a potentially large set of 
additional transitive dependencies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to