mark-bathori commented on code in PR #9145: URL: https://github.com/apache/nifi/pull/9145#discussion_r1720953511
########## nifi-extension-bundles/nifi-iceberg-bundle/nifi-iceberg-services/src/main/java/org/apache/nifi/services/iceberg/JdbcCatalogService.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.services.iceberg; + +import org.apache.nifi.annotation.documentation.CapabilityDescription; +import org.apache.nifi.annotation.documentation.Tags; +import org.apache.nifi.annotation.lifecycle.OnEnabled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.controller.ConfigurationContext; +import org.apache.nifi.dbcp.DBCPService; +import org.apache.nifi.expression.ExpressionLanguageScope; +import org.apache.nifi.processor.util.StandardValidators; + +import java.util.List; + +import static org.apache.nifi.services.iceberg.IcebergCatalogProperty.FILE_IO_IMPLEMENTATION; +import static org.apache.nifi.services.iceberg.IcebergCatalogProperty.CLIENT_POOL_SERVICE; +import static org.apache.nifi.services.iceberg.IcebergCatalogProperty.CLIENT_POOL_SIZE; +import static org.apache.nifi.services.iceberg.IcebergCatalogProperty.WAREHOUSE_LOCATION; + +@Tags({"iceberg", "catalog", "service", "jdbc"}) +@CapabilityDescription("Catalog service using relational database to manage Iceberg tables through JDBC.") +public class JdbcCatalogService extends AbstractCatalogService { + + public static final PropertyDescriptor CATALOG_NAME = new PropertyDescriptor.Builder() + .name("Catalog Name") + .description("Name of the Iceberg catalog.") + .addValidator(StandardValidators.NON_BLANK_VALIDATOR) + .defaultValue("jdbc-catalog") + .required(true) + .expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT) + .build(); + + public static final PropertyDescriptor CONNECTION_POOL = new PropertyDescriptor.Builder() + .name("Connection Pool") + .description("Specifies the JDBC Connection Pool to use in order to communicate with the Iceberg catalog.") + .identifiesControllerService(DBCPService.class) + .required(true) + .build(); + + public static final PropertyDescriptor CONNECTION_POOL_SIZE = new PropertyDescriptor.Builder() + .name("Connection Pool Size") + .description("Specifies the size of the JDBC Connection Pool.") + .defaultValue("2") + .required(true) + .addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR) + .build(); + + public static final PropertyDescriptor FILE_IO_IMPL = new PropertyDescriptor.Builder() + .name("File IO Implementation") + .description("Specifies the implementation of FileIO interface to be used. " + + "The provided implementation have to include the class and full package name.") + .defaultValue("org.apache.iceberg.hadoop.HadoopFileIO") Review Comment: Currently we have the HadoopFileIO and 3 cloud specific IO implementation (S3, ADLS, GCS) so I think we can make a fix list as you suggested. Custom FileIO implementation can be made but I think it's enough to support these. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
