szaszm commented on code in PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1736081140
##########
cmake/GetZLIB.cmake:
##########
Review Comment:
There is some issue with the zlib conan build, I'm getting missing headers.
Did you test compilation with the zlib headers not installed on the system?
```
In file included from
/home/szaszm/nifi-minifi-cpp/build_conan/extensions/librdkafka/kafka-external-prefix/src/kafka-external/src/rdkafka_buf.h:32,
from
/home/szaszm/nifi-minifi-cpp/build_conan/extensions/librdkafka/kafka-external-prefix/src/kafka-external/src/rdkafka_int.h:88,
from
/home/szaszm/nifi-minifi-cpp/build_conan/extensions/librdkafka/kafka-external-prefix/src/kafka-external/src/rdavl.c:29:
/home/szaszm/nifi-minifi-cpp/build_conan/extensions/librdkafka/kafka-external-prefix/src/kafka-external/src/rdcrc32.h:57:10:
fatal error: zlib.h: No such file or directory
57 | #include <zlib.h>
| ^~~~~~~~
compilation terminated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
