james94 commented on code in PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1737196067
##########
cmake/GetZLIB.cmake:
##########
Review Comment:
**UPDATED (Sept 1, 2024)**: @szaszm
I just double checked the **conanfile.py**, it appears zlibs is not in conan
package **shared_requires** tuple. I realized some other conan packages
depended on **zlib**, so conan automatically downloaded **zlib 1.3.1** prebuilt
conan package. I will add it explicitly. Here will be the updated
**shared_requires** tuple
~~~bash
shared_requires = ("openssl/3.2.1", "libcurl/8.6.0", "civetweb/1.16",
"libxml2/2.12.6", "fmt/10.2.1", "spdlog/1.14.0", "catch2/3.5.4", "zlib/1.3.1")
~~~
I will try **zlib/1.3.1** for conan package, which is different
**zlib/1.2.11** system library version. We shouldn't see that missing headers
from zlib during compilation anymore, but if we do, I will use zlib's CMake
variables to provide the path to the needed headers.
I will double check by manually building MiNiFi with conan and get back to
you, but for now, I updated the **conanfile.py** with **zlib** added to the
**shared_requires** tuple and its on the repo now @szaszm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
