martinzink commented on code in PR #1885:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1885#discussion_r1819060099
##########
extensions/kafka/KafkaConnection.h:
##########
@@ -80,9 +82,9 @@ class KafkaConnection {
KafkaConnectionKey key_;
- std::map<std::string, std::shared_ptr<KafkaTopic>> topics_;
+ std::map<std::string, std::shared_ptr<KafkaTopic>> topics_{};
- gsl::owner<rd_kafka_t*> kafka_connection_;
+ gsl::owner<rd_kafka_t*> kafka_connection_{};
Review Comment:
here the ownership is contained within this class so RAII will apply, and
the destruction is dependent on other class members so the changes would be
nontrivial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
