martinzink commented on code in PR #1885:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1885#discussion_r1820313445
##########
extensions/kafka/ConsumeKafka.h:
##########
@@ -219,9 +217,13 @@ class ConsumeKafka : public KafkaProcessorBase {
ADD_COMMON_VIRTUAL_FUNCTIONS_FOR_PROCESSORS
- explicit ConsumeKafka(std::string_view name, const utils::Identifier& uuid =
utils::Identifier()) :
+ explicit ConsumeKafka(const std::string_view name, const utils::Identifier&
uuid = utils::Identifier()) :
Review Comment:
@szaszm beat me to it with a nice explanation :+1:, but yeah afaik the
constness of the argument only matters in the definition for the parameters
mutability, and it has no effect in the declaration.
Here I've added it because we have the declaration and the definition in the
same place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
