martinzink commented on PR #1885: URL: https://github.com/apache/nifi-minifi-cpp/pull/1885#issuecomment-2447360017
> There are a lot of if statements that went from multiline from single line, and some property builder calls that are also on a single long line now. I don't think that's necessarily a readability improvement, unless the statement is trivial. > > If your IDE did it automatically, I suggest to turn off automatic shortening to a single line. If you did it manually after a conscious decision, then it's fine, I'm rarely criticizing formatting style choices, but I would be less aggressive with putting too much logic on a single line. I've utilized the new .clang-format to reformat the extension, I agree that its a bit aggressive so I've refined the clang-format so we don't target the linter's 200 long max line length, but rather a more reasonable 125. I don't want to manually correct these so I think its better to correct the clang-format file (if possible) so we can safely autoformat the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
