exceptionfactory commented on code in PR #10:
URL:
https://github.com/apache/nifi-python-extensions/pull/10#discussion_r1833186947
##########
src/extensions/vectorstores/OpenSearchVectorUtils.py:
##########
@@ -74,12 +80,16 @@
def create_authentication_params(context):
username = context.getProperty(USERNAME).getValue()
password = context.getProperty(PASSWORD).getValue()
+ certificate_path = context.getProperty(CERTIFICATE_PATH).getValue()
- params = {"verify_certs": "true"}
Review Comment:
@mark-bathori is there a particular reason for removing this `verify_certs`
property? Does it somehow conflict with specifying a custom certificate? It
seems like it should remain in place and only be changed when a custom
certificate is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
