mark-bathori commented on code in PR #10:
URL:
https://github.com/apache/nifi-python-extensions/pull/10#discussion_r1835781429
##########
src/extensions/vectorstores/OpenSearchVectorUtils.py:
##########
@@ -74,12 +80,16 @@
def create_authentication_params(context):
username = context.getProperty(USERNAME).getValue()
password = context.getProperty(PASSWORD).getValue()
+ certificate_path = context.getProperty(CERTIFICATE_PATH).getValue()
- params = {"verify_certs": "true"}
Review Comment:
Thanks @exceptionfactory for the review. I removed the flag because it is
automatically set based on the provided url. If the url is using **https**
scheme then the **use_ssl** property will be set to true in the
[utils.py](https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/client/utils.py#L70)
and because of that value the **verify_certs** will be set to true in the
[http_urllib3.py](https://github.com/opensearch-project/opensearch-py/blob/main/opensearchpy/connection/http_urllib3.py#L189).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
