adamdebreceni commented on code in PR #1902:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1902#discussion_r1867797100
##########
core/include/minifi-cpp/core/PropertyDefinition.h:
##########
@@ -33,17 +32,17 @@ struct PropertyDefinition {
std::string_view name;
std::string_view display_name;
std::string_view description;
- bool is_required = false;
- bool is_sensitive = false;
+ bool is_required;
+ bool is_sensitive;
std::array<std::string_view, NumAllowedValues> allowed_values;
std::span<const std::string_view> allowed_types;
std::array<std::string_view, NumDependentProperties> dependent_properties;
std::array<std::pair<std::string_view, std::string_view>,
NumExclusiveOfProperties> exclusive_of_properties;
std::optional<std::string_view> default_value;
- gsl::not_null<const PropertyType*>
type{gsl::make_not_null(&StandardPropertyTypes::VALID_TYPE)};
- bool supports_expression_language = false;
+ gsl::not_null<const PropertyType*> type;
+ bool supports_expression_language;
- uint8_t version = 1;
+ uint8_t version;
Review Comment:
so StandardPropertyTypes does not have to be part of the api, since we are
creating these through PropertyDefinitionBuilder anyway the default values have
been moved there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
