szaszm commented on code in PR #1902:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1902#discussion_r1918203802
##########
extensions/mqtt/processors/PublishMQTT.h:
##########
@@ -23,25 +23,25 @@
#include <utility>
#include <vector>
-#include "FlowFileRecord.h"
-#include "RelationshipDefinition.h"
+#include "core/RelationshipDefinition.h"
#include "core/Processor.h"
-#include "RelationshipDefinition.h"
#include "core/ProcessSession.h"
#include "core/PropertyDefinitionBuilder.h"
#include "core/Core.h"
#include "core/Property.h"
-#include "core/logging/LoggerConfiguration.h"
+#include "core/logging/LoggerFactory.h"
#include "AbstractMQTTProcessor.h"
#include "utils/ArrayUtils.h"
#include "utils/gsl.h"
+#include "core/ProcessorMetrics.h"
namespace org::apache::nifi::minifi::processors {
class PublishMQTT : public processors::AbstractMQTTProcessor {
public:
explicit PublishMQTT(std::string_view name, const utils::Identifier& uuid =
{})
- : processors::AbstractMQTTProcessor(name, uuid,
std::make_shared<PublishMQTTMetrics>(*this, in_flight_message_counter_)) {
+ : processors::AbstractMQTTProcessor(name, uuid) {
+ metrics_ = gsl::make_not_null(std::make_shared<PublishMQTTMetrics>(*this,
in_flight_message_counter_));
Review Comment:
is there a reason for moving this out of the ctor init list?
##########
extensions/standard-processors/processors/GetFile.h:
##########
@@ -82,10 +81,11 @@ class GetFileMetrics : public core::ProcessorMetrics {
std::atomic<uint64_t> input_bytes{0};
};
-class GetFile : public core::Processor {
+class GetFile : public core::ProcessorImpl {
public:
explicit GetFile(std::string_view name, const utils::Identifier& uuid = {})
- : Processor(name, uuid, std::make_shared<GetFileMetrics>(*this)) {
+ : ProcessorImpl(name, uuid) {
+ metrics_ = gsl::make_not_null(std::make_shared<GetFileMetrics>(*this));
Review Comment:
same here, but I won't spam any more comments if I encounter more of the same
##########
extensions/rocksdb-repos/CMakeLists.txt:
##########
@@ -30,8 +30,9 @@ file(GLOB SOURCES "*.cpp" "controllers/*.cpp"
"database/*.cpp" "encryption/*.cp
add_minifi_library(minifi-rocksdb-repos SHARED ${SOURCES})
-target_link_libraries(minifi-rocksdb-repos ${LIBMINIFI} Threads::Threads)
-target_link_libraries(minifi-rocksdb-repos RocksDB::RocksDB)
+target_link_libraries(minifi-rocksdb-repos PUBLIC RocksDB::RocksDB)
+target_link_libraries(minifi-rocksdb-repos PUBLIC minifi-core
minifi-extension-utils Threads::Threads)
+target_link_libraries(minifi-rocksdb-repos PRIVATE $<LINK_ONLY:core-minifi>)
Review Comment:
having both minifi-core and core-minifi is confusing, we should rename at
least one of them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
